Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add regression tests for F5 and F8 saving to history#1914

Merged
andyleejordan merged 1 commit into
mainPowerShell/PowerShellEditorServices:mainfrom
andschwa/history-regressionPowerShell/PowerShellEditorServices:andschwa/history-regressionCopy head branch name to clipboard
Sep 1, 2022
Merged

Add regression tests for F5 and F8 saving to history#1914
andyleejordan merged 1 commit into
mainPowerShell/PowerShellEditorServices:mainfrom
andschwa/history-regressionPowerShell/PowerShellEditorServices:andschwa/history-regressionCopy head branch name to clipboard

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

This tests both the PowerShell history and the PSReadLine history via a stub, since we can't load PSReadLine itself in these tests.

Covers PowerShell/vscode-powershell#3683 and #1823.

This tests both the PowerShell history and the PSReadLine history via a
stub, since we can't load PSReadLine itself in these tests.
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Aug 31, 2022
@andyleejordan andyleejordan requested a review from a team August 31, 2022 21:51
@andyleejordan andyleejordan mentioned this pull request Aug 31, 2022
@andyleejordan

Copy link
Copy Markdown
Member Author

@brwilkinson hey look, a regression test 🥳

@andyleejordan andyleejordan enabled auto-merge (squash) August 31, 2022 22:16

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 5ddc688 into main Sep 1, 2022
@andyleejordan andyleejordan deleted the andschwa/history-regression branch September 1, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Test Issue-Enhancement A feature request (enhancement).

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.