Add regression tests for parse error DiagnosticMarkers#1872
Merged
andyleejordan merged 2 commits intoAug 4, 2022
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
fflaten:parseerrormarkers-testsfflaten/PowerShellEditorServices:parseerrormarkers-testsCopy head branch name to clipboard
Merged
Add regression tests for parse error DiagnosticMarkers#1872andyleejordan merged 2 commits intoPowerShell:mainPowerShell/PowerShellEditorServices:mainfrom fflaten:parseerrormarkers-testsfflaten/PowerShellEditorServices:parseerrormarkers-testsCopy head branch name to clipboard
andyleejordan merged 2 commits into
PowerShell:mainPowerShell/PowerShellEditorServices:mainfrom
fflaten:parseerrormarkers-testsfflaten/PowerShellEditorServices:parseerrormarkers-testsCopy head branch name to clipboard
Conversation
Contributor
Author
|
@andschwa Forgotten tests-debt paid with interest 🙂 |
andyleejordan
approved these changes
Aug 4, 2022
andyleejordan
left a comment
Member
There was a problem hiding this comment.
Beautiful, thank you so much 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Regression tests to verify diagnostic markers for parse errors are:
PR Context
No tests for this feature AFAIK.
Broke this momentarily while working on #1869