Fix logic checking for untitled or raw scripts#1839
Merged
andyleejordan merged 1 commit intoJun 22, 2022
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/untitled-checkPowerShell/PowerShellEditorServices:andschwa/untitled-checkCopy head branch name to clipboard
Merged
Fix logic checking for untitled or raw scripts#1839andyleejordan merged 1 commit intomasterPowerShell/PowerShellEditorServices:masterfrom andschwa/untitled-checkPowerShell/PowerShellEditorServices:andschwa/untitled-checkCopy head branch name to clipboard
andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/untitled-checkPowerShell/PowerShellEditorServices:andschwa/untitled-checkCopy head branch name to clipboard
Conversation
This was much more easily accomplished by checking if what we were given exists as a file path, in which case we use it as-is (a file path, that must exist, since we launch it directly). Otherwise we can assume that it's a raw script block, or a URI from the client that probably represents an untitled file.
Member
Author
|
Fixes a bug introduced in #1830 |
SeeminglyScience
approved these changes
Jun 22, 2022
| // Script could an actual script, or a URI to a script file (or untitled document). | ||
| if (!System.Uri.IsWellFormedUriString(scriptToLaunch, System.UriKind.RelativeOrAbsolute) | ||
| || ScriptFile.IsUntitledPath(scriptToLaunch)) | ||
| if (System.IO.File.Exists(scriptToLaunch)) |
Collaborator
There was a problem hiding this comment.
I think this is going to break for remote files (e.g. you do an interactive Enter-PSSession and then psedit ./something.ps1) but that's also probably super broken atm anyway. Something we should revisit in the future, but definitely not a blocker to getting this fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was much more easily accomplished by checking if what we were given
exists as a file path, in which case we use it as-is (a file path, that
must exist, since we launch it directly). Otherwise we can assume that
it's a raw script block, or a URI from the client that probably
represents an untitled file.