Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add regression test for accidentally allowing removal of $psEditor#1828

Merged
andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/pseditor-testPowerShell/PowerShellEditorServices:andschwa/pseditor-testCopy head branch name to clipboard
Jun 14, 2022
Merged

Add regression test for accidentally allowing removal of $psEditor#1828
andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/pseditor-testPowerShell/PowerShellEditorServices:andschwa/pseditor-testCopy head branch name to clipboard

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

This adds a regression test for PowerShell/vscode-powershell#3718.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Jun 14, 2022
@andyleejordan andyleejordan requested a review from a team June 14, 2022 00:12
@andyleejordan

Copy link
Copy Markdown
Member Author

@SeeminglyScience Do you see a better way to write this test?

Comment thread test/PowerShellEditorServices.Test/Extensions/ExtensionCommandTests.cs Outdated
@andyleejordan andyleejordan force-pushed the andschwa/pseditor-test branch from 0493ec3 to e1c1550 Compare June 14, 2022 19:05
@andyleejordan andyleejordan enabled auto-merge (squash) June 14, 2022 19:24

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@andyleejordan andyleejordan merged commit 5f08df6 into master Jun 14, 2022
@andyleejordan andyleejordan deleted the andschwa/pseditor-test branch June 14, 2022 21:45
@andyleejordan andyleejordan mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Test Issue-Enhancement A feature request (enhancement).

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.