Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Emacs regression tests for PSES#1820

Merged
andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/emacs-testPowerShell/PowerShellEditorServices:andschwa/emacs-testCopy head branch name to clipboard
Jun 10, 2022
Merged

Add Emacs regression tests for PSES#1820
andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/emacs-testPowerShell/PowerShellEditorServices:andschwa/emacs-testCopy head branch name to clipboard

Conversation

@andyleejordan

@andyleejordan andyleejordan commented Jun 9, 2022

Copy link
Copy Markdown
Member

This adds regression tests written in Emacs to validate that PSES can be connected (and reports diagnostics) with a client that isn't VS Code, namely Eglot, and Emacs LSP client.

@andyleejordan andyleejordan force-pushed the andschwa/emacs-test branch from 986b1e5 to a3c3dc3 Compare June 9, 2022 18:01
@andyleejordan andyleejordan marked this pull request as ready for review June 9, 2022 18:10
@andyleejordan andyleejordan requested a review from a team June 9, 2022 18:10
@andyleejordan andyleejordan requested a review from a team as a code owner June 9, 2022 18:10
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Jun 9, 2022
@andyleejordan

Copy link
Copy Markdown
Member Author

Should prevent #1695 from recurring.

@andyleejordan andyleejordan enabled auto-merge (squash) June 9, 2022 19:18
This adds regression tests written in Emacs to validate that PSES can be
connected (and reports diagnostics) with a client that isn't VS Code,
namely [Eglot](https://github.com/joaotavora/eglot).
@andyleejordan andyleejordan force-pushed the andschwa/emacs-test branch from a3c3dc3 to 69e4793 Compare June 9, 2022 22:42

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM!

@andyleejordan andyleejordan merged commit 8d57124 into master Jun 10, 2022
@andyleejordan andyleejordan deleted the andschwa/emacs-test branch June 10, 2022 18:10
@andyleejordan andyleejordan mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build & Release Issue-Enhancement A feature request (enhancement).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.