Handle debuggerResult being null in ProcessDebuggerResult#1670
Merged
andyleejordan merged 1 commit intoJan 19, 2022
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/fix-null-derefPowerShell/PowerShellEditorServices:andschwa/fix-null-derefCopy head branch name to clipboard
Merged
Handle debuggerResult being null in ProcessDebuggerResult#1670andyleejordan merged 1 commit intomasterPowerShell/PowerShellEditorServices:masterfrom andschwa/fix-null-derefPowerShell/PowerShellEditorServices:andschwa/fix-null-derefCopy head branch name to clipboard
debuggerResult being null in ProcessDebuggerResult#1670andyleejordan merged 1 commit into
masterPowerShell/PowerShellEditorServices:masterfrom
andschwa/fix-null-derefPowerShell/PowerShellEditorServices:andschwa/fix-null-derefCopy head branch name to clipboard
Conversation
Not entirely sure why this can be the case, but a stacktrace from a null dereference crash indicates it can be null. Since the existing logic is only doing something if the `ResumeAction` field is not null, I assume we similarly do nothing if the entire object is also null (since that implies the former, too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not entirely sure why this can be the case, but a stacktrace from a null
dereference crash indicates it can be null. Since the existing logic is
only doing something if the
ResumeActionfield is not null, I assumewe similarly do nothing if the entire object is also null (since that
implies the former, too).
Fixes #1672