Centralize module loading#1520
Closed
dkattan wants to merge 7 commits into
PowerShell:masterPowerShell/PowerShellEditorServices:masterfrom
dkattan:centralize-module-loadingdkattan/PowerShellEditorServices:centralize-module-loadingCopy head branch name to clipboard
Closed
Centralize module loading#1520dkattan wants to merge 7 commits intoPowerShell:masterPowerShell/PowerShellEditorServices:masterfrom dkattan:centralize-module-loadingdkattan/PowerShellEditorServices:centralize-module-loadingCopy head branch name to clipboard
dkattan wants to merge 7 commits into
PowerShell:masterPowerShell/PowerShellEditorServices:masterfrom
dkattan:centralize-module-loadingdkattan/PowerShellEditorServices:centralize-module-loadingCopy head branch name to clipboard
Conversation
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.2 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.2...13.0.1) Signed-off-by: dependabot[bot] <support@github.com>
…3.0.1 Bump Newtonsoft.Json from 12.0.2 to 13.0.1
Contributor
Author
|
Closing as #1516 includes these changes |
Contributor
Author
|
Re-opening as #1516 didn't end up centralizing the module loading, just the PSReadLine changes. |
192d25e to
65ff98d
Compare
65ff98d to
d1c5e1a
Compare
Contributor
Author
|
Will resubmit new merge request with squashed commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #1514 and is a pre-requisite for
#1516 and #1507
By centralizing all module loading into PowerShellContextService.cs, we can more easily honor the -BundledModulesPath parameter as we aren't building the relative path to our modules folder in multiple locations. Additionally, since we have all the information we need in PowerShellContextService to determine which modules will be necessary, we can load them all using a method compatible with the runspace, as Import-Module isn't always available and sometimes you need to use initialSessionState.ImportPSModuleFromPath