Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable#256

Merged
TravisEz13 merged 10 commits into
PowerShell:masterPowerShell/PowerShell-Docker:masterfrom
adityapatwardhan:AddDistChanneladityapatwardhan/PowerShell-Docker:AddDistChannelCopy head branch name to clipboard
Aug 8, 2019
Merged

Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable#256
TravisEz13 merged 10 commits into
PowerShell:masterPowerShell/PowerShell-Docker:masterfrom
adityapatwardhan:AddDistChanneladityapatwardhan/PowerShell-Docker:AddDistChannelCopy head branch name to clipboard

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Aug 1, 2019

Copy link
Copy Markdown
Member

PR Summary

Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable to all images.

PR Checklist

Comment thread release/preview/alpine38/docker/Dockerfile
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}

ARG fromTag=7
ARG imageRepo=centos

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imageRepo is unused

@ghost ghost added the Waiting on Author label Aug 5, 2019
@ghost ghost removed the Waiting on Author label Aug 5, 2019
Comment thread release/preview/alpine38/dependabot/Dockerfile Outdated
@adityapatwardhan

Copy link
Copy Markdown
Member Author

@TravisEz13 can you update your review?

@TravisEz13 TravisEz13 merged commit 8da8107 into PowerShell:master Aug 8, 2019
@ghost

ghost commented Aug 12, 2019

Copy link
Copy Markdown

🎉20190812 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.