Move processing of -WorkingDirectory before processing of profiles for pwsh.exe#8079
Merged
adityapatwardhan merged 1 commit intoOct 29, 2018
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:console-working-dirSteveL-MSFT/PowerShell:console-working-dirCopy head branch name to clipboard
Merged
Move processing of -WorkingDirectory before processing of profiles for pwsh.exe#8079adityapatwardhan merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom SteveL-MSFT:console-working-dirSteveL-MSFT/PowerShell:console-working-dirCopy head branch name to clipboard
-WorkingDirectory before processing of profiles for pwsh.exe#8079adityapatwardhan merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:console-working-dirSteveL-MSFT/PowerShell:console-working-dirCopy head branch name to clipboard
Conversation
50b5a96 to
b51af84
Compare
bergmeister
approved these changes
Oct 19, 2018
bergmeister
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I tested it and it works well. Thanks :-)
Member
Author
|
@PowerShell/powershell-committee reviewed this and agree with the change |
adityapatwardhan
approved these changes
Oct 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Without this change, the processing of
-WorkingDirectoryhappens after processing$PROFILE(all the profiles). This means that any$PROFILEthat explicitly usesSet-Locationto a desired folder will be ovewritten by-WorkingDirectory ~which is added to the shortcut for pwsh by default.The fix is to move the processing of
-WorkingDirectorybefore processing of profiles. Note that this is abreaking changefor any$PROFILEthat expects to start in $PSHOME instead of~but it seems unlikely.Fix #7895
Fix #8144
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests