Build and package framework dependent package#7729
Merged
TravisEz13 merged 2 commits intoSep 10, 2018
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FrameworkDependentPwshadityapatwardhan/PowerShell:FrameworkDependentPwshCopy head branch name to clipboard
Merged
Build and package framework dependent package#7729TravisEz13 merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:FrameworkDependentPwshadityapatwardhan/PowerShell:FrameworkDependentPwshCopy head branch name to clipboard
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FrameworkDependentPwshadityapatwardhan/PowerShell:FrameworkDependentPwshCopy head branch name to clipboard
Conversation
TravisEz13
reviewed
Sep 7, 2018
TravisEz13
reviewed
Sep 7, 2018
11 tasks
Contributor
|
Although the changes look 'reasonable', it's difficult for me to determine if the results actually work for the intended purpose. Is there any way we can create a test verify the result? |
|
UpdatableHelpSystem failures in PowerShell-CI-linux. |
daxian-dbw
reviewed
Sep 8, 2018
Member
Author
|
@anmenaga The failures are due to "Network unreachable" issue when downloading from download center. Other help tests work as they are downloading help from Azure blob storage. |
Member
Author
|
@dantraMSFT I have filed an issue to tracking adding new tests for framework dependent package #7750 |
anmenaga
approved these changes
Sep 10, 2018
Member
|
travis-ci finished and did not update: https://travis-ci.org/PowerShell/PowerShell/builds/426798974?utm_source=github_status&utm_medium=notification |
TravisEz13
pushed a commit
that referenced
this pull request
Sep 10, 2018
Add the functionality to build a framework dependent (shared framework) package for PowerShell. The changes create two packages, one for Windows and other for Linux, due to #if code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add the functionality to build a framework dependent (shared framework) package for PowerShell.
The changes create two packages, one for Windows and other for Linux, due to
#ifcode.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests