Use dotnet-resgen to compile resx files by andyleejordan · Pull Request #743 · PowerShell/PowerShell

andyleejordan · Mar 26, 2016

Improvement

Specifically this enables us to leverage dotnet-resgen to auto-generate the resx files into resources files for the default culture, which are then compiled into the respective assemblies.

@vors Since .resources no longer need to be compiled on Windows and added to windows-build, #732 should be updated to map the .resx files into the superproject as well.

Requires PowerShell/psl-windows-build#10.

Caveat

This requires a change to the C# bindings. The Windows build system takes file.resx and compiles file.resources, but CLI prepends the assembly name, thus compiling SMA.file.resources. So the resource manager in the generated bindings must be adjusted to look for SMA.file instead of file.

Note that C# bindings cannot yet be auto-generated; so if they need to be updated, the above must be changed again. This is still blocked on #395 / dotnet/cli#819. However, the C# bindings need to be updated only if strings are added/removed, not when their content changes.

Localization

@vors I've discovered that given localized resources of the form file.en-US.resx, dotnet-resgen will create a satellite assembly and publish it to en-US/SMA.resources.dll, so #666 will not be a technical problem.

/cc @SteveL-MSFT @BrucePay @dantraMSFT

This change is

Needs to be `processName`, not `program`. Go figure.

Specifically this enables us to leverage `dotnet-resgen` to auto-generate the `resx` files into `resources` files for the default culture, which are then compiled into the SMA assembly. This requires a change to the C# bindings. The Windows build system takes `file.resx` and compiles `file.resources`, but CLI prepends the assembly name, thus compiling `SMA.file.resources`. So the resource manager in the generated bindings must be adjusted to look for `SMA.file` instead of `file`. Note that C# bindings cannot yet be auto-generated. Given localized resources of the form `file.en-US.resx`, `dotnet-resgen` will create a satellite assembly and publish it to `en-US/SMA.resources.dll`, so #666 will not be a technical problem.

This is a runtime dependency that causes an internal exception to be thrown and caught when not available.

So that the resource manager doesn't try to load a non-existent satellite assembly (and thus throw). The culture `en-US` is the default `CurrentCulture` on all platforms I tested, specifically not `en`. Note that there is a problem with the FullCLR build where some other assembly is still attempting to reference `Logging.resources` instead of `System.Management.Automation.Logging.resources`.

andyleejordan · Mar 27, 2016

@vors I'm going to need some help making this work with the FullCLR build. There is a problem with the FullCLR build where some other assembly is still attempting to reference Logging.resources instead of
System.Management.Automation.Logging.resources, but I can't figure out which assembly is doing so. This is causing the build to fail because the host fails to initialize.

vors · Mar 27, 2016

ok, lets take a look on Tuesday

andyleejordan · Mar 28, 2016

Here it is:

C:\Users\anschwa\src\PowerShell [andschwa/wip-culture ≡ +0 ~2 -0 !]> Start-DevPSGitHub -binDir $pwd\binFull -NoNewWindow
 -ArgumentList '-command', '[System.Globalization.CultureInfo]::CurrentUICulture'
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.
The shell cannot be started. A failure occurred during initialization:
Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "Logging.resources
" was correctly embedded or linked into assembly "System.Management.Automation" at compile time, or that all the satelli
te assemblies required are loadable and fully signed.

This error would make sense if SMA's resource C# bindings had not been fixed. However, as evidenced from Core and Linux working, SMA indeed is fine.

So what, outside of our code, would be using SMA's resource bindings directly?

andyleejordan · Mar 28, 2016

Found it. The EventLog code uses a ResourceManager directly and manually tried to load the resources file (rather than through the C# bindings), so a use there had to be updated too.

This now requires PowerShell/psl-monad#42 too.

andyleejordan added 8 commits March 26, 2016 15:27

Fix VS Code attach debugging configuration

18ba3f3

Needs to be `processName`, not `program`. Go figure.

Replace Utility's namedResource section with resource

3979d4c

Replace Management's namedResource section with resource

76fd8bd

Replace Security's namedResource section with resource

b363fc9

Replace ConsoleHost's namedResource section with resource

af92960

Replace Eventing's namedResource section with resource

3d8a3b9

Bump windows-build submodule with resources fixes

aedaf53

andyleejordan added the in progress label Mar 26, 2016

andyleejordan added 2 commits March 26, 2016 17:26

Add System.IO.MemoryMappedFiles dependency

6433650

This is a runtime dependency that causes an internal exception to be thrown and caught when not available.

Fix use of ResourceManager in monad

eb93841

andyleejordan merged commit 7057c4b into master Mar 28, 2016

andyleejordan removed the in progress label Mar 28, 2016

andyleejordan deleted the andschwa/cli-resources branch March 28, 2016 18:27

This was referenced Mar 28, 2016

Use C# bindings in EventLog code #745

Closed

Remove C# bindings from windows-build submodule #746

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use dotnet-resgen to compile resx files#743

Use dotnet-resgen to compile resx files#743
andyleejordan merged 11 commits into
masterPowerShell/PowerShell:masterfrom
andschwa/cli-resourcesPowerShell/PowerShell:andschwa/cli-resourcesCopy head branch name to clipboard

andyleejordan commented Mar 26, 2016

Uh oh!

andyleejordan commented Mar 27, 2016

Uh oh!

vors commented Mar 27, 2016

Uh oh!

andyleejordan commented Mar 28, 2016

Uh oh!

andyleejordan commented Mar 28, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Conversation

andyleejordan commented Mar 26, 2016

Improvement

Caveat

Localization

Uh oh!

andyleejordan commented Mar 27, 2016

Uh oh!

vors commented Mar 27, 2016

Uh oh!

andyleejordan commented Mar 28, 2016

Uh oh!

andyleejordan commented Mar 28, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants