Move to dotnet 2.1.301 by iSazonov · Pull Request #7161 · PowerShell/PowerShell

iSazonov · Jun 25, 2018

PR Summary

Move to latest dotnet version - 2.1.301
Log dotnet --info
Add RuntimeFrameworkVersion 2.1.1

PR Checklist

…Common.props

iSazonov · Jun 25, 2018

@markekraus Could you please look the issue with WebListener on Ci Appveyor?

markekraus · Jun 25, 2018

@iSazonov I must be missing something... don't see any weblistener issues. I do see an issue with Files.wxs and I see an issue with accessing nuget repos.. but that doesn't have anything to do with web listener as far as I can tell.

Don't you also need to add <RuntimeFrameworkVersion>2.1.1</RuntimeFrameworkVersion> to the test/Test.Common.props file?

You might even need version bumps in test/tools/WebListener/WebListener.csproj?

iSazonov · Jun 25, 2018

@markekraus I meat

Restoring packages for C:\projects\powershell\test\tools\WebListener\WebListener.csproj...
 99  Restoring packages for C:\projects\powershell\test\tools\WebListener\WebListener.csproj...
 100  Retrying 'FindPackagesByIdAsync' for source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.httpoverrides/index.json'.
 101  The HTTP request to 'GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.httpoverrides/index.json' has timed out after 100000ms.
 102  Retrying 'FindPackagesByIdAsync' for source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.mvc.abstractions/index.json'.
 103  The HTTP request to 'GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.mvc.abstractions/index.json' has timed out after 100000ms.
 104  Retrying 'FindPackagesByIdAsync' for source 'https://powershell.myget.org/F/powershell

markekraus · Jun 25, 2018

@iSazonov those are nuget errors.. not issues with WebListener. Could be network issue in AppVeyor. or anything between AppVeyor and the various nuget feeds it is timing out on.

SteveL-MSFT · Jun 25, 2018

            </Component>
-            <Component Id="cmp8777CA81FBD5C5FAC86993893043793D" Guid="{B2D9982B-D46A-4D69-AA16-CC7EC49D357F}">
-                <File Id="fil9A6CE1B34698E9E81BC367B9E9CEBF25" KeyPath="yes" Source="$(env.ProductSourcePath)\sos_$(var.FileArchitecture)_$(var.FileArchitecture)_4.6.26515.07.dll" />
+-            <Component Id="cmp94bba02944344967a5b4abedb5e5ad21" Guid="{0e836bc9-94c6-42f2-b213-2990d06172be}">


You don't have to update the GUIDs/IDs. Not sure, but the wix error might be expecting GUIDs to be all uppercase?

If the file name changed, you should change either the Id or the GUID. Any patching scenario would require it and we should always assume we will be required to patch even previews.

Should I fix only case or something else?

I'm guessing that the case is what you need to fix. The error is not very useful when compared to the change.

anmenaga · Jun 25, 2018

Is there patch notes for version 301 ?

SteveL-MSFT · Jun 25, 2018

@anmenaga Release notes are here https://github.com/dotnet/core/blob/master/release-notes/2.1/2.1.1.md

daxian-dbw · Jun 26, 2018

        $env:PATH = $originalPath
+    } else {
+        $dotnetInfo = (dotnet --info)
+        Write-Log "dotnet --info: `n$dotnetInfo"


dontet --info would be too verbose I think. How about just use "dotnet --version"?

Really this is needed only for moving to new .Net Core versions. I think we could remove the logging at all. dotnet --version is not so useful because don't show versions of all components.

Removing sounds good to me.

daxian-dbw · Jun 26, 2018

@iSazonov With 2.1.1, can you please verify if the fix about File.Attributes on the special operating system files (hiberfil.sys, pagefile.sys and swapfile.sys) are working properly? This is regarding our discussions at #6929 (comment)

anmenaga · Jun 26, 2018

From where were the updated package version numbers taken from? e.g:
<PackageReference Include="System.ServiceModel.Primitives" Version="4.5.1" />
Can you please help me understand the link how a new package number like example above was associated with new dotnet version?

iSazonov · Jun 27, 2018

@anmenaga I don't know package numbering schema. Seems 4.4.x is for .Net Core 2.0 and 4.5.x for 2.1.
We use Get-NewOfficalPackage from our tools\releaseTools.psm1 to check packages versions.

iSazonov · Jun 27, 2018

@daxian-dbw Yes, we got the fix in 2.1.1 - I checked on CI artifact builds from the both PRs.

daxian-dbw

@iSazonov I have removed the logging code in build.psm1.

iSazonov requested review from TravisEz13, adityapatwardhan, anmenaga and daxian-dbw as code owners June 25, 2018 07:43

iSazonov requested a review from SteveL-MSFT June 25, 2018 07:43

iSazonov assigned daxian-dbw Jun 25, 2018

iSazonov added 2 commits June 25, 2018 12:48

[Feature] Move to dotnet 2.1.301

bc3ea97

[Feature] Update versions of packages

28202bd

iSazonov force-pushed the move-to-2.1.301 branch from 9c62ad2 to 28202bd Compare June 25, 2018 09:50

[Feature] Update System.ServiceModel.Primitives version

cc85770

iSazonov force-pushed the move-to-2.1.301 branch from cd97825 to cc85770 Compare June 25, 2018 10:47

Add <RuntimeFrameworkVersion>2.1.1</RuntimeFrameworkVersion> in Test.…

d35de90

…Common.props

Remove unneeded components from Files.wxs

f339a03

Add new components

d9d5380

SteveL-MSFT requested changes Jun 25, 2018

View reviewed changes

Fix case

06389ed

SteveL-MSFT approved these changes Jun 26, 2018

View reviewed changes

daxian-dbw reviewed Jun 26, 2018

View reviewed changes

Remove the logging

fa4db60

daxian-dbw approved these changes Jun 28, 2018

View reviewed changes

daxian-dbw merged commit 839ecb8 into PowerShell:master Jun 29, 2018

iSazonov deleted the move-to-2.1.301 branch June 29, 2018 06:12

Search code, repositories, users, issues, pull requests...

Conversation

iSazonov commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

iSazonov commented Jun 25, 2018

Uh oh!

markekraus commented Jun 25, 2018

Uh oh!

iSazonov commented Jun 25, 2018

Uh oh!

markekraus commented Jun 25, 2018

Uh oh!

SteveL-MSFT Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

anmenaga commented Jun 25, 2018

Uh oh!

SteveL-MSFT commented Jun 25, 2018

Uh oh!

daxian-dbw Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

daxian-dbw commented Jun 26, 2018

Uh oh!

anmenaga commented Jun 26, 2018

Uh oh!

iSazonov commented Jun 27, 2018

Uh oh!

iSazonov commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iSazonov commented Jun 25, 2018 •

edited

Loading

TravisEz13 Jun 25, 2018 •

edited

Loading

iSazonov commented Jun 27, 2018 •

edited

Loading