install-powershell.sh filter prereleases (when available), params documentation#6849
install-powershell.sh filter prereleases (when available), params documentation#6849TravisEz13 merged 6 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom DarwinJS:installerprereleasesupportDarwinJS/PowerShell:installerprereleasesupportCopy head branch name to clipboard
Conversation
|
@TravisEz13 - I can't recall what to do about spelling errors in MD files - can you please remind me what we did last time? |
|
You need to add the missing words in this section https://github.com/PowerShell/PowerShell/blob/master/.spelling#L215 |
|
@TravisEz13 - Looks like this is failing at the OSX sudo password prompt? How to handle this? Thanks! https://travis-ci.org/PowerShell/PowerShell/jobs/380487406 |
|
@DarwinJS |
|
Is there a way to detect CI? Is checking for POWERSHELL_TELEMETRY_OPTOUT=1 good enough or is there a better way? There have not been any complaints about the sudo check (that I know of) beyond CI. FYI - I updated the sudo check to be non-interactive. |
|
most CI systems, except VSTS define a variable called |
|
@TravisEz13 - I put in place the skipping of the sudo check, but also skipped sudo assuming I had admin. So is the magic that I DO need to use SUDO - but I can't check for it? How has this not been failing for months - it used to work without any special SUDO handling, but didn't break until I touched it. Can you look at the build log? |
|
My statement about Also, you should look at the package renaming during preview.3 and see if this affects your change. |
|
@TravisEz13 - builds are passing - should I remove "WIP" ? |
* Fix syntax error for issue 7903. Typo come from #6849 * Add identation after copyright message
PR Summary
Fixed #6815 by adding -allowprereleases parameter
Fixed #6405 by adding -allowprereleases parameter
Added parameters to documentation
Ready for prerelease repositories if Microsoft starts providing them
Added -skip-sudo-check for all distros
Fixed -interactivetesting should do nothing if -includeide was not used
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests@TravisEz13 - If you create pre-release repos as per #6496 this switch can be used to add those repo links in the relevant distro install scripts. Currently it just issues a warning that whatever is on the repo dictates whether pre-releases will be installed.