Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix version test to allow not to have a pre-release portion.#5893

Merged
TravisEz13 merged 2 commits into
PowerShell:6.0.0PowerShell/PowerShell:6.0.0from
TravisEz13:fix_regexTravisEz13/PowerShell:fix_regexCopy head branch name to clipboard
Jan 15, 2018
Merged

fix version test to allow not to have a pre-release portion.#5893
TravisEz13 merged 2 commits into
PowerShell:6.0.0PowerShell/PowerShell:6.0.0from
TravisEz13:fix_regexTravisEz13/PowerShell:fix_regexCopy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Jan 13, 2018

Copy link
Copy Markdown
Member

PR Summary

fix version test to allow not to have a pre-release portion.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@TravisEz13 TravisEz13 requested a review from daxian-dbw January 13, 2018 00:35
@iSazonov

iSazonov commented Jan 13, 2018

Copy link
Copy Markdown
Collaborator

Should we review C# code for PSVersion? We use a regex there.

Update: never mind.

@TravisEz13 TravisEz13 merged commit ab9a583 into PowerShell:6.0.0 Jan 15, 2018
@TravisEz13 TravisEz13 deleted the fix_regex branch January 15, 2018 17:34
@TravisEz13 TravisEz13 added this to the 6.0.1 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.