Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace HttpListener Redirect Tests with WebListener#5872

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:ReplaceHttpListenerRedirectmarkekraus/PowerShell:ReplaceHttpListenerRedirectCopy head branch name to clipboard
Jan 13, 2018
Merged

Replace HttpListener Redirect Tests with WebListener#5872
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:ReplaceHttpListenerRedirectmarkekraus/PowerShell:ReplaceHttpListenerRedirectCopy head branch name to clipboard

Conversation

@markekraus

@markekraus markekraus commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

PR Summary

(assuming #5806 and #5840 are merged first. after which... all tests will be on WebListener only 🎉 ).

  • adds type query to Redirect listener and adjusts logic to accommodate
  • Replaces HttpListener Redirect Tests with WebListener

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@iSazonov iSazonov requested review from SteveL-MSFT and removed request for TravisEz13 January 12, 2018 04:25
@iSazonov iSazonov self-assigned this Jan 12, 2018

@iSazonov iSazonov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit 211ee63 into PowerShell:master Jan 13, 2018
@markekraus markekraus deleted the ReplaceHttpListenerRedirect branch January 19, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.