Fix Pull request Template Typo and Markdown Linting Error#5807
Merged
daxian-dbw merged 1 commit intoJan 8, 2018
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:PRTemplateSpellingFixmarkekraus/PowerShell:PRTemplateSpellingFixCopy head branch name to clipboard
Merged
Fix Pull request Template Typo and Markdown Linting Error#5807daxian-dbw merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom markekraus:PRTemplateSpellingFixmarkekraus/PowerShell:PRTemplateSpellingFixCopy head branch name to clipboard
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:PRTemplateSpellingFixmarkekraus/PowerShell:PRTemplateSpellingFixCopy head branch name to clipboard
Conversation
bergmeister
approved these changes
Jan 6, 2018
bergmeister
left a comment
Contributor
There was a problem hiding this comment.
LGTM but the PR title has a typo: Markdonw -> Markdown
Contributor
Author
|
@bergmeister lol.. thanks.. corrected. |
daxian-dbw
approved these changes
Jan 8, 2018
Contributor
|
@markekraus It gets even better, the merge commit contains the original typo in the commit message (I always thought it was the PR title that forms the basis of the squash commit but I seem to be wrong). Nevermind, no one is going to notice/care. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Jan 9, 2018
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
affectes->affectsPR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.