Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Build.psm1 - Update Restore-PSPester to include the fix for nested describe errors#5771

Merged
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dantraMSFT:psl-pesterCopy head branch name to clipboard
Jan 3, 2018
Merged

Build.psm1 - Update Restore-PSPester to include the fix for nested describe errors#5771
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dantraMSFT:psl-pesterCopy head branch name to clipboard

Conversation

@dantraMSFT

@dantraMSFT dantraMSFT commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Update Restore-PSPester to include PR PowerShell/psl-pester#12 that fixes PowerShell/psl-pester#11 - unhandled exceptions in before/after bypasses Pester's enddescribe logic.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • [PR has a meaningful title]
    • Use the present tense and imperative mood when describing your changes
  • [Summarized changes]
  • [ NA] User facing [Documentation needed]
  • Issue filed - Issue link: $script:SafeCommands is null in the finally block of the Decribe function. psl-pester#11
  • [Change is not breaking]
  • [NA ] [Make sure you've added a new test if existing tests do not effectively test the code changed]
    • [NA ] [Add [feature] if the change is significant or affectes feature tests]
  • This PR is ready to merge and is not [Work in Progress]

@TravisEz13

Copy link
Copy Markdown
Member

Please use the PR Template and follow the instruction for feature changes

@dantraMSFT dantraMSFT changed the title Update psl-pester commit id to handle fix for nested describe errors Build.psm1 - Update Restore-PSPester to include the fix for nested describe errors Jan 2, 2018
Comment thread build.psm1 Outdated
)

Restore-GitModule -Destination $Destination -Uri 'https://github.com/PowerShell/psl-pester' -Name Pester -CommitSha 'aa243108e7da50a8cf82513b6dd649b653c70b0e'
Restore-GitModule -Destination $Destination -Uri 'https://github.com/PowerShell/psl-pester' -Name Pester -CommitSha '87f531db89a91db86736ac11b4e565ad10c3e334'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we take the latest change? PowerShell/psl-pester@1f546b6

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixed.

@TravisEz13 TravisEz13 merged commit b057d45 into PowerShell:master Jan 3, 2018
@dantraMSFT dantraMSFT deleted the psl-pester branch January 4, 2018 00:24
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Jan 5, 2018
… errors (PowerShell#5771)

Update Restore-PSPester to include PR PowerShell/psl-pester#12 that fixes PowerShell/psl-pester#11 - unhandled exceptions in before/after bypasses Pester's enddescribe logic.  
Update to the latest, while we are at it.
TravisEz13 pushed a commit that referenced this pull request Jan 5, 2018
… errors (#5771)

Update Restore-PSPester to include PR PowerShell/psl-pester#12 that fixes PowerShell/psl-pester#11 - unhandled exceptions in before/after bypasses Pester's enddescribe logic.  
Update to the latest, while we are at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$script:SafeCommands is null in the finally block of the Decribe function.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.