Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add instructions to deploy PSCore6 on Windows IoT arm32#5682

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:install-winarmSteveL-MSFT/PowerShell:install-winarmCopy head branch name to clipboard
Dec 15, 2017
Merged

add instructions to deploy PSCore6 on Windows IoT arm32#5682
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:install-winarmSteveL-MSFT/PowerShell:install-winarmCopy head branch name to clipboard

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

PR Summary

Update README.md to include win-arm build and link to installation instructions. Add section to windows.md installation instructions specifically for Windows IoT. Added Experimental labels to win-arm and linux-arm packages since dotnetcore doesn't formally support them yet and we haven't fully tested them.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@anmenaga anmenaga left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

Comment thread docs/installation/windows.md Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Travis CI detected spelling error in this line about "PSSession".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSSession is a class name, so maybe we should put it in a code block (enclose it with ``). If so, we don't need to change the .spelling file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, will change.

@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-RC.2, 6.0.0-GA Dec 13, 2017

@anmenaga anmenaga left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis updated the readme.md to include win-arm32 and win-arm64 zip packages in #5688. Can you please review that and give your feedback?

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments.

@daxian-dbw daxian-dbw dismissed their stale review December 14, 2017 23:42

New commit has been pushed.

@daxian-dbw

Copy link
Copy Markdown
Member

@SteveL-MSFT Travis has incorporated your changes in README.md in his PR (which has been merged), so you can revert the changes in README.md.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

@daxian-dbw removed README.md from this PR

@daxian-dbw daxian-dbw merged commit 462833b into PowerShell:master Dec 15, 2017
@SteveL-MSFT SteveL-MSFT deleted the install-winarm branch December 15, 2017 22:25
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 19, 2017
@TravisEz13 TravisEz13 mentioned this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.