Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make the experience better when start-pspester doesn't find pester#5673

Merged
TravisEz13 merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:fix_pester_restoreTravisEz13/PowerShell:fix_pester_restoreCopy head branch name to clipboard
Dec 13, 2017
Merged

Make the experience better when start-pspester doesn't find pester#5673
TravisEz13 merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:fix_pester_restoreTravisEz13/PowerShell:fix_pester_restoreCopy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Dec 12, 2017

Copy link
Copy Markdown
Member

PR Summary

  • refactor code to restore pester into a separate function called Restore-PSPester
  • update message on what to do when pester is missing
  • Add ability for get-psoptions to default to new-psoptions
  • fix an issue with publish-pstesttools when a build has not been run since build.psm1 has been imported (try to use the default options)
  • make start-pspester use the last build, not just use the default options
  • fix an issue in restore caused some files not to be removed

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@markekraus markekraus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and Thank you!!!

@TravisEz13 TravisEz13 removed this from the 6.0.0-RC.2 milestone Dec 12, 2017
@SteveL-MSFT

Copy link
Copy Markdown
Member

Can you address #5640 in the same PR?

@TravisEz13

Copy link
Copy Markdown
Member Author

Added two commits for the docs. One to make them pass unit tests and one to make the updates for easier review.

Comment thread build.psm1 Outdated
Pester module not found.
Make sure that the proper git submodules are installed by running:
git submodule update --init
Restore to module to '$Pester' by running:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the first to extra?

@SteveL-MSFT SteveL-MSFT added this to the 6.0.0-RC.2 milestone Dec 12, 2017
@TravisEz13 TravisEz13 merged commit 6ef94c1 into PowerShell:master Dec 13, 2017
@TravisEz13 TravisEz13 deleted the fix_pester_restore branch December 13, 2017 00:07
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Dec 13, 2017
…owerShell#5673)

refactor code to restore pester into a separate function called Restore-PSPester
update message on what to do when pester is missing
Add ability for get-psoptions to default to new-psoptions
fix an issue with publish-pstesttools when a build has not been run since build.psm1 has been imported (try to use the default options)
make start-pspester use the last build, not just use the default options
fix an issue in restore caused some files not to be removed
TravisEz13 added a commit that referenced this pull request Dec 13, 2017
…5673)

refactor code to restore pester into a separate function called Restore-PSPester
update message on what to do when pester is missing
Add ability for get-psoptions to default to new-psoptions
fix an issue with publish-pstesttools when a build has not been run since build.psm1 has been imported (try to use the default options)
make start-pspester use the last build, not just use the default options
fix an issue in restore caused some files not to be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.