Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Exclude markdown files from 'Pester' folder#5636

Merged
daxian-dbw merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:fixbuilddaxian-dbw/PowerShell:fixbuildCopy head branch name to clipboard
Dec 6, 2017
Merged

Exclude markdown files from 'Pester' folder#5636
daxian-dbw merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:fixbuilddaxian-dbw/PowerShell:fixbuildCopy head branch name to clipboard

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Dec 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Exclude markdown files from powershell.AppDir folder which is temporary for AppImage creation.
From https://travis-ci.org/PowerShell/PowerShell/jobs/312145407

The command "pwsh -File tools/travis.ps1" exited with 0.
1.82s$ if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then mdspell '**/*.md' '!**/publish/**/*.md' --ignore-numbers --ignore-acronyms --report; fi
    powershell/powershell.AppDir/usr/bin/Modules/Pester/CHANGELOG.md
        2 | ed versions of that command. [GH-362]

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@daxian-dbw daxian-dbw requested a review from TravisEz13 December 6, 2017 01:39
@TravisEz13

TravisEz13 commented Dec 6, 2017

Copy link
Copy Markdown
Member

should be run with [package]

TravisEz13
TravisEz13 approved these changes Dec 6, 2017
View reviewed changes

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be verified with a [package] commit

@daxian-dbw daxian-dbw changed the title Exclude markdown files from 'powershell.AppDir' folder Exclude markdown files from 'Pester' folder Dec 6, 2017
JamesWTruher
JamesWTruher approved these changes Dec 6, 2017
View reviewed changes

@JamesWTruher JamesWTruher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 9a12349 into PowerShell:master Dec 6, 2017
@daxian-dbw daxian-dbw deleted the fixbuild branch December 6, 2017 20:11
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017
@daxian-dbw @TravisEz13
Exclude markdown files from 'Pester' folder (PowerShell#5636)
4524688
@TravisEz13 TravisEz13 mentioned this pull request Dec 7, 2017
Merged
TravisEz13 pushed a commit that referenced this pull request Dec 7, 2017
@daxian-dbw @TravisEz13
Exclude markdown files from 'Pester' folder (#5636)
f837b04
@TravisEz13 TravisEz13 added this to the 6.0.0-RC.2 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

4 participants

@daxian-dbw @TravisEz13 @JamesWTruher @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.