Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update test to construct the version from $PSVersionTable.PSVersion#5557

Closed
daxian-dbw wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:FixCIdaxian-dbw/PowerShell:FixCICopy head branch name to clipboard
Closed

Update test to construct the version from $PSVersionTable.PSVersion#5557
daxian-dbw wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:FixCIdaxian-dbw/PowerShell:FixCICopy head branch name to clipboard

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Two tests related to *-PSSessionConfiguration failed (see the failure below). The tests failed because the powershell built from the master branch is now with the version v6.1.0-preview.1, but we hardcoded the expected version to be 6.0. The fix is to generate the expected version from $PSVersionTable.PSVersion.

Describing Validate Register-PSSessionConfiguration, Set-PSSessionConfiguration cmdlets
   Context Validate Register-PSSessionConfiguration
    [-] Validate Register-PSSessionConfiguration -name -path 14.51s
      Expected: {6}
      But was:  {6.1}
      at line: 491 in C:\projects\powershell-f975h\test\powershell\Modules\Microsoft.PowerShell.Core\PSSessionConfiguration.Tests.ps1
      491:                     $Result.Session.PSVersion | Should be 6.0
   Context Validate Set-PSSessionConfiguration
    [-] Validate Set-PSSessionConfiguration -name -path -MaximumReceivedObjectSizeMB -MaximumReceivedDataSizePerCommandMB -UseSharedProcess -ThreadOptions parameters 27.69s
      Expected: {6}
      But was:  {6.1}
      at line: 560 in C:\projects\powershell-f975h\test\powershell\Modules\Microsoft.PowerShell.Core\PSSessionConfiguration.Tests.ps1
      560:                     $Result.Session.PSVersion | Should be 6.0

@adityapatwardhan

Copy link
Copy Markdown
Member

@daxian-dbw There is a PR open to resolve the issue. #5554

@daxian-dbw

Copy link
Copy Markdown
Member Author

@adityapatwardhan Ah, thanks. I forgot it.

@daxian-dbw daxian-dbw closed this Nov 28, 2017
@daxian-dbw daxian-dbw deleted the FixCI branch November 28, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.