Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Import-CliXml Test#5521

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:FixImportCliXmlTestmarkekraus/PowerShell:FixImportCliXmlTestCopy head branch name to clipboard
Nov 22, 2017
Merged

Fix Import-CliXml Test#5521
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:FixImportCliXmlTestmarkekraus/PowerShell:FixImportCliXmlTestCopy head branch name to clipboard

Conversation

@markekraus

Copy link
Copy Markdown
Contributor

I noticed that there was an error in the Import-CliXml context but no failed tests. It turns out this was working because it was exporting null and then checking if null is null.. 🙁

This fixes the error generated by get-process and ensure the imported values are not null or empty.

@markekraus markekraus changed the title Fix Import-CliXml Tests Fix Import-CliXml Test Nov 21, 2017
@iSazonov iSazonov self-assigned this Nov 22, 2017
@iSazonov iSazonov merged commit 7778941 into PowerShell:master Nov 22, 2017
@TravisEz13 TravisEz13 added this to the 6.0.0-GA milestone Nov 29, 2017
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 29, 2017
Add checks that ProcessName is not null or empty.
TravisEz13 pushed a commit that referenced this pull request Nov 29, 2017
Add checks that ProcessName is not null or empty.
@markekraus markekraus deleted the FixImportCliXmlTest branch January 19, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.