Add a test for the powershell hang fix#5451
Merged
Merged
Add a test for the powershell hang fix#5451
Conversation
adityapatwardhan
requested changes
Nov 14, 2017
| exit | ||
| '@ | ||
| $process = Start-Process pwsh -ArgumentList $command -PassThru | ||
| for ($i = 0; -not $process.HasExited -and $i -lt 5; $i++) { |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
OK, I will use Wait-UntilTrue
| Start-Sleep -Seconds 1 | ||
| } | ||
|
|
||
| $expect = "powershell process exits in 5 seconds" |
Member
There was a problem hiding this comment.
Should the verification be like:
$process.HasExited | Should Be $true
Stop-Process $process -ErrorAction SilentlyContinue
Member
Author
There was a problem hiding this comment.
The Should be $true check will not generate a useful error message when it fails, so I prefer to the current check. But I will add -ErrorAction SilentlyContinue
Member
Author
|
@adityapatwardhan Your comments are addressed. Please take another look. Thanks! |
adityapatwardhan
approved these changes
Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for the fix in PR #5356
Also add a minor change to build.psm1 to ignore the 'Sync-PSTags' warning.