Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove 'oldPowershellExeName' contains powershell.exe#5408

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
chunqingchen:bugfix_1chunqingchen/PowerShell:bugfix_1Copy head branch name to clipboard
Dec 6, 2017
Merged

Remove 'oldPowershellExeName' contains powershell.exe#5408
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
chunqingchen:bugfix_1chunqingchen/PowerShell:bugfix_1Copy head branch name to clipboard

Conversation

@chunqingchen

Copy link
Copy Markdown
Contributor

This is to resolve #5135

@SteveL-MSFT SteveL-MSFT added this to the 6.0.0-HighPriority milestone Nov 11, 2017
@lzybkr lzybkr removed their request for review November 16, 2017 00:31
@chunqingchen

Copy link
Copy Markdown
Contributor Author

@daxian-dbw hi dongbo, could you please take a look?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old deps file should be removed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old deps file.

@TravisEz13 TravisEz13 modified the milestones: 6.0.0-GA, 6.0.0-RC.2 Dec 6, 2017
@daxian-dbw daxian-dbw dismissed their stale review December 6, 2017 20:40

New commit has been pushed to address the comment.

@daxian-dbw daxian-dbw requested review from adityapatwardhan and removed request for BrucePay December 6, 2017 20:41
@daxian-dbw daxian-dbw self-assigned this Dec 6, 2017
@daxian-dbw

Copy link
Copy Markdown
Member

@adityapatwardhan Can you please take a look at this PR? Thanks!

@daxian-dbw daxian-dbw merged commit 4f4d779 into PowerShell:master Dec 6, 2017
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove 'oldPowershellExeName' from 'RemoveSxSPsHomeModulePath' before RC/GA

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.