Add PSTypeName Support for Import-Csv and ConvertFrom-Csv#5389
Add PSTypeName Support for Import-Csv and ConvertFrom-Csv#5389TravisEz13 merged 3 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom markekraus:ImportCsvTypeDatamarkekraus/PowerShell:ImportCsvTypeDataCopy head branch name to clipboard
Conversation
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one comment.
There was a problem hiding this comment.
Please add:
$importTypes.Count | Should Be $expectedProcessTypes.CountThere was a problem hiding this comment.
Please move the line before $importTypes[0].
And please add such check in other It.
|
@SteveL-MSFT CI Travis don't report status - can PG investigate the issue? |
|
@iSazonov seems to be an ongoing issue with Travis-CI. Looking at the actual results, it passed on both macOS and Linux, so we are good. |
|
@SteveL-MSFT It seems I haven't permission to manually merge - (protected branch hook declined). Or I do something wrong. |
|
@SteveL-MSFT It seems the problem with CI Travis coming from #5249 |
|
@markekraus can you rebase and pick up #5249? |
0d9f62a to
6d5af16
Compare
|
Rebased. |
|
@SteveL-MSFT *shrugs. Rebased and the Travis CI tests passed, but they still are not updating the PR to reflect that. |
|
Merging with macOS still not finished. Talked to other maintainers and we think the risk is low. |
closes #5134
Import-CsvandConvertFrom-CsvA note for reviewers: the logic for adding the type name was moved to after the object's properties are populated to prevent
Cannot add a member with the name "<PorpertyName>" because a member with that name already existserrors during object serialization.