Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Exclude EventResource.resx from SMAResources.Tests.ps1#5379

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
dantraMSFT:dantra/issue5378Copy head branch name to clipboard
Nov 9, 2017
Merged

Exclude EventResource.resx from SMAResources.Tests.ps1#5379
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
dantraMSFT:dantra/issue5378Copy head branch name to clipboard

Conversation

@dantraMSFT

@dantraMSFT dantraMSFT commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

[Feature]
Fix #5378
EventResource.resx does not have a generated C# class.

@daxian-dbw

Copy link
Copy Markdown
Member

@dantraMSFT the [Feature] needs to be put in the commit message, not in the PR description.

@SteveL-MSFT

Copy link
Copy Markdown
Member

@dantraMSFT on this branch, just do a git commit --amended and update the commit message so that the first line is [Feature], then git push --force

@daxian-dbw

Copy link
Copy Markdown
Member

Something is wrong with the macOS CI. The log shows the build passed, however the CI itself is shown as broken: https://travis-ci.org/PowerShell/PowerShell/jobs/299363616

I will merge this PR.

@daxian-dbw daxian-dbw merged commit 7a78fec into PowerShell:master Nov 9, 2017
@dantraMSFT dantraMSFT deleted the dantra/issue5378 branch November 9, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.