Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update Wix toolset download link in error message to newer version 3.11 (same as CI)#5339

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
bergmeister:patch-1bergmeister/PowerShell:patch-1Copy head branch name to clipboard
Nov 6, 2017
Merged

Update Wix toolset download link in error message to newer version 3.11 (same as CI)#5339
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
bergmeister:patch-1bergmeister/PowerShell:patch-1Copy head branch name to clipboard

Conversation

@bergmeister

@bergmeister bergmeister commented Nov 4, 2017

Copy link
Copy Markdown
Contributor

This makes it also future proof because:

  • Codeplexx is going to get deprecated and the new link links directly to the GitHub repository.
  • Only version 3.11 enabled support for Visual Studio 2017.

I have tested locally (on a machine that does not have the old WiX v 3.10 but only the new version 3.11) that building the installer still works.

@bergmeister
Update Wix toolset download link to newer version 3.11
a998e8c 
This makes it also future proof since codeplexx is going to get deprecated.
@TravisEz13

TravisEz13 commented Nov 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Can someone test the package https://ci.appveyor.com/project/bergmeister/powershell/build/artifacts ~~

  • Windows 10
  • Windows 8.1
  • Windows 7 - x64

@bergmeister

bergmeister commented Nov 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@TravisEz13 This PR only changes the error message displayed to someone who tries to build PowerShell locally but does not have WiX installed (in fact the check is not against a specific version). Therefore it does not change the build itself, hence no need for testing.
In your appveyor.yml file here, the Visual Studio 2017 image is specified, which already has WiX Toolset 3.11.0.1701

@TravisEz13

TravisEz13 commented Nov 5, 2017

Copy link
Copy Markdown
Member

Sorry, just going through a lot of PRs quickly.

@bergmeister bergmeister changed the title Update Wix toolset download link to newer version 3.11 Update Wix toolset download link in error message to newer version 3.11 (same as CI) Nov 5, 2017
@daxian-dbw daxian-dbw merged commit 6b700bb into PowerShell:master Nov 6, 2017
@iSazonov

iSazonov commented Jan 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@bergmeister Maybe replace the link with https://github.com/wixtoolset/wix3/releases/tag/wix3111rtm and suggest to install latest version ?

@bergmeister

bergmeister commented Jan 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Or just https://github.com/wixtoolset/wix3/releases to future proof it since WiX 4 is in a separate repo anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergmeister @TravisEz13 @iSazonov @daxian-dbw
Morty Proxy This is a proxified and sanitized view of the page, visit original site.