Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace pwsh with powershell in VS Code tasks.json for Windows#5327

Closed
iSazonov wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:revert-vscode-use-powershelliSazonov/PowerShell:revert-vscode-use-powershellCopy head branch name to clipboard
Closed

Replace pwsh with powershell in VS Code tasks.json for Windows#5327
iSazonov wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:revert-vscode-use-powershelliSazonov/PowerShell:revert-vscode-use-powershellCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Nov 3, 2017

Copy link
Copy Markdown
Collaborator

Problem

It is impossible to build and debug from VS Code on Windows - VS Code cannot find pwsh.exe.

Fix

Use powershell.exe on Windows to build.

@SteveL-MSFT

Copy link
Copy Markdown
Member

pwsh should be in the PATH with beta.9

@iSazonov

iSazonov commented Nov 4, 2017

Copy link
Copy Markdown
Collaborator Author

What if I don't install Beta.9?

@SteveL-MSFT

Copy link
Copy Markdown
Member

But isn't this file only used with PSCore6? Eventually we will only support the final release which will be called pwsh.

@iSazonov

iSazonov commented Nov 7, 2017

Copy link
Copy Markdown
Collaborator Author

By default Windows don't have pwsh.exe installed. Currently we can not build PowerShell Core 6.0 on Windows from VS Code until we install PowerShell Core 6.0 >=Beta.9 but can from command line. On Unix we have to install PowerShell Core 6.0 in any case because we deprecate install.sh.
So question is - Shall we continue support build PowerShell Core with Windows PowerShell or no? If we continue build from command line why we don't support to build from VS Code?

@SteveL-MSFT

Copy link
Copy Markdown
Member

@iSazonov I see. I wasn't thinking about the initial bootstrap issue, however, it would seem like this is an edge case as we're getting closer to a final version of 6.0.0. I expect the significant majority of people building PSCore6 to be using the build.psm1 module. The only time I ever build PSCore6 from VSCode is when debugging something.

@iSazonov

iSazonov commented Nov 7, 2017

Copy link
Copy Markdown
Collaborator Author

We should document if PowerShell Core 6.0 is mandatory prerequest on Windows now or better add in BootStrap (check latest version?).

@SteveL-MSFT

SteveL-MSFT commented Nov 7, 2017

Copy link
Copy Markdown
Member

I like the suggestion to have it in Start-PSBootStrap. Created issue #5367

I'll submit a doc update: #5368

@iSazonov

iSazonov commented Nov 7, 2017

Copy link
Copy Markdown
Collaborator Author

Ok, I close the PR because we'll have pwsh.exe with Start-PSBootStrap.

@iSazonov iSazonov closed this Nov 7, 2017
@iSazonov iSazonov deleted the revert-vscode-use-powershell branch November 8, 2017 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.