Refactor for signing#5300
Merged
TravisEz13 merged 6 commits intoNov 2, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:refactor_for_signingTravisEz13/PowerShell:refactor_for_signingCopy head branch name to clipboard
Merged
Refactor for signing#5300TravisEz13 merged 6 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom TravisEz13:refactor_for_signingTravisEz13/PowerShell:refactor_for_signingCopy head branch name to clipboard
TravisEz13 merged 6 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:refactor_for_signingTravisEz13/PowerShell:refactor_for_signingCopy head branch name to clipboard
Conversation
TravisEz13
commented
Nov 1, 2017
Member
- make symbols zip include the crossgen'ed files
- make symbols zip include a zip for the publish folder.
- make symbols zip not allow PSModuleRestore
require -CrossGen on build for -includeSymbols disallow -PSRestoreModule for includeSymbols
adityapatwardhan
approved these changes
Nov 1, 2017
| elseif ($IncludeSymbols.IsPresent) { | ||
| $crossGenCorrect = $true | ||
|
|
||
| $PSModuleRestoreCorrect = $false |
Member
There was a problem hiding this comment.
Please add comments about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.