Add global.json to pick correct SDK version#5118
Add global.json to pick correct SDK version#5118daxian-dbw merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom rkeithhill:rkeithhill/add-global-jsonrkeithhill/PowerShell:rkeithhill/add-global-jsonCopy head branch name to clipboard
Conversation
| "sdk": { | ||
| "version": "2.0.0" | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file.
There was a problem hiding this comment.
Done. BTW the original file was simply the output of running:
dotnet new global.json --sdk-version 2.0.0
|
@daxian-dbw Could you please review this bit change? It looks very good. |
|
Any update on this? I'm constantly having to create this file on every new branch I create. Otherwise, I can't build. Plus this allows the PowerShell team to specify which version of the SDK is requires. This will reduce contributor issues when their build fails with the message above. And when the team is ready to move to a later version of the SKD like 2.0.2, the global.json can be updated to reflect that change. |
|
@rkeithhill Thanks for this PR! Sorry that we had it slipped off our radar. |
Fix #5015
This sets the version of the dotnet SDK that should be used to compile the project. I happen to have newer version of the SDK (2.0.2) on my machine and without this file, the build attempts to use the newer version of the SDK which doesn't work.
BTW if you have 2.0.2 installed, without this file when you run
Start-PSBuildyou get this warning and the build stops - even if you have 2.0.0 installed: