Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix detection of whether -LiteralPath was used to suppress wildcardexpansion for navigation cmdlets#5038

Merged
adityapatwardhan merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:remove-item-wildcardSteveL-MSFT/PowerShell:remove-item-wildcardCopy head branch name to clipboard
Oct 9, 2017
Merged

fix detection of whether -LiteralPath was used to suppress wildcardexpansion for navigation cmdlets#5038
adityapatwardhan merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:remove-item-wildcardSteveL-MSFT/PowerShell:remove-item-wildcardCopy head branch name to clipboard

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

Fix #5031

fix detection of whether `-LiteralPath` was used to suppress wildcardexpansion

@adityapatwardhan adityapatwardhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan

Copy link
Copy Markdown
Member

@SteveL-MSFT The test 'Remove-Item -LiteralPath should succeed for file with asterisk in name' is failing. Please fix.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

@adityapatwardhan I only ran it on my Mac, I need to skip it on Windows since asterisk isn't allowed in filename

skip -literalpath test with asterisk in filename as that's not valid on Windows
@adityapatwardhan

Copy link
Copy Markdown
Member

@SteveL-MSFT Please add the test as described in the issue #5031. That should work on Windows as well.

added more variations of tests
@SteveL-MSFT

Copy link
Copy Markdown
Member Author

@adityapatwardhan added more test variations for the wildcard not finding files scenario

@adityapatwardhan adityapatwardhan merged commit ff59be3 into PowerShell:master Oct 9, 2017
@SteveL-MSFT SteveL-MSFT deleted the remove-item-wildcard branch October 9, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.