SetServiceCommand: Add positional parameter attribute#5017
Merged
adityapatwardhan merged 2 commits intoOct 9, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
travisty-:feature/service-command-parametersCopy head branch name to clipboard
Merged
SetServiceCommand: Add positional parameter attribute#5017adityapatwardhan merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom travisty-:feature/service-command-parametersCopy head branch name to clipboard
adityapatwardhan merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
travisty-:feature/service-command-parametersCopy head branch name to clipboard
Conversation
Added a positional parameter attribute to the InputObject parameter, giving Set-Service behavior similar to the other *-Service cmdlets.
|
|
Member
|
@travisty- Please add tests for the new scenario at: https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Management/Set-Service.Tests.ps1 |
Contributor
Author
|
Hi @adityapatwardhan @daxian-dbw, tests have been added for this scenario. |
Collaborator
|
@travisty- Thanks for your contribution! We should split formatting changes and code changes - this makes it easier to review and support code. Also if new test is under "Feature" CI tag please add |
Added a test to Set-Service validating InputObjects passed positionally.
Contributor
Author
|
Thanks for the feedback @iSazonov. I'll submit the formatting improvements in a separate PR. |
iSazonov
approved these changes
Oct 8, 2017
adityapatwardhan
approved these changes
Oct 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.
Closes #4916.