increase timing on test service for webcmdlet timeout test to make it more robust#5005
Merged
mirichmo merged 1 commit intoOct 5, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:webcmdlet-timeout-testSteveL-MSFT/PowerShell:webcmdlet-timeout-testCopy head branch name to clipboard
Merged
increase timing on test service for webcmdlet timeout test to make it more robust#5005mirichmo merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom SteveL-MSFT:webcmdlet-timeout-testSteveL-MSFT/PowerShell:webcmdlet-timeout-testCopy head branch name to clipboard
mirichmo merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:webcmdlet-timeout-testSteveL-MSFT/PowerShell:webcmdlet-timeout-testCopy head branch name to clipboard
Conversation
dantraMSFT
approved these changes
Oct 4, 2017
This was referenced Oct 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test service had a delay of 5s while the test had a timeout of 5s, there's a small window where the delay expires before the timeout invalidating the test.
Fix is to increase the delay to 6s allowing for the timeout to succeed.
VSCode removed a bunch of trailing whitespace.