Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update version of PSDesiredStateConfiguration in project files#4979

Merged
Indhukrishna merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
Indhukrishna:insivara/UpdatePSDesiredStateConfiguration/1710Indhukrishna/PowerShell:insivara/UpdatePSDesiredStateConfiguration/1710Copy head branch name to clipboard
Oct 3, 2017
Merged

Update version of PSDesiredStateConfiguration in project files#4979
Indhukrishna merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
Indhukrishna:insivara/UpdatePSDesiredStateConfiguration/1710Indhukrishna/PowerShell:insivara/UpdatePSDesiredStateConfiguration/1710Copy head branch name to clipboard

Conversation

@Indhukrishna

@Indhukrishna Indhukrishna commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

This PR has the project dependency changes for updating version of PSDesiredStateConfiguration module. The module has been fixed to enable Dsc configuration compilation on Windows with PowerShell 6.0.0.0

Resolves #4570

@adityapatwardhan adityapatwardhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Indhukrishna Indhukrishna merged commit 417e988 into PowerShell:master Oct 3, 2017
@Indhukrishna Indhukrishna deleted the insivara/UpdatePSDesiredStateConfiguration/1710 branch October 3, 2017 04:07
@SteveL-MSFT

Copy link
Copy Markdown
Member

Do we have tests for this?

@Indhukrishna

Copy link
Copy Markdown
Contributor Author

@SteveL-MSFT We have some tests that we are adding to the other repo. When we make more updates to this module, we will add those tests.

@SteveL-MSFT

Copy link
Copy Markdown
Member

@Indhukrishna it would be great if you can add some basic tests to this repo to make sure things don't accidentally get broken

@Indhukrishna

Copy link
Copy Markdown
Contributor Author

@SteveL-MSFT Got it. Will do as soon as I am back in office.

@TravisEz13

Copy link
Copy Markdown
Member

@Indhukrishna Please use a rebase merge unless there is a need to preserve the history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DSC Configurations should work on windows

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.