Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add new Fwlinks for v6 help content#4978

Merged
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:HelpUriadityapatwardhan/PowerShell:HelpUriCopy head branch name to clipboard
Oct 23, 2017
Merged

Add new Fwlinks for v6 help content#4978
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:HelpUriadityapatwardhan/PowerShell:HelpUriCopy head branch name to clipboard

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Oct 2, 2017

Copy link
Copy Markdown
Member

No description provided.

@joeyaiello

joeyaiello commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

Didn't check them all, but I spot-checked a few and they look right to me.

Are you planning on getting the content uploaded before the merge so that we know everything is passing? Or is there a chicken/egg problem there?

@adityapatwardhan

adityapatwardhan commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

Working on updating the help content with the correct fwlinks. We would need to move it to 'live' before these tests pass. Then we can merge.

SteveL-MSFT
SteveL-MSFT approved these changes Oct 2, 2017
View reviewed changes

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan changed the title [Feature] Add new Fwlinks for v6 help content Add new Fwlinks for v6 help content Oct 5, 2017
daxian-dbw
daxian-dbw requested changes Oct 6, 2017
View reviewed changes
Comment thread src/Modules/Shared/PSReadLine/PSReadLine.psd1 Outdated

@daxian-dbw daxian-dbw Oct 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this quote put on a new line intentionally?

@adityapatwardhan adityapatwardhan Oct 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@daxian-dbw daxian-dbw self-assigned this Oct 6, 2017
@daxian-dbw

daxian-dbw commented Oct 6, 2017

Copy link
Copy Markdown
Member

There are some failures in CI runs. Can you please fix them?

@adityapatwardhan

adityapatwardhan commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

The failures are because the help content is wrong. I am fixing it in a different repo. The failures in CI are dependent on this PR: MicrosoftDocs/PowerShell-Docs#1735

@adityapatwardhan adityapatwardhan mentioned this pull request Oct 9, 2017
Merged
8 tasks
@lzybkr lzybkr removed their request for review October 10, 2017 02:09
@adityapatwardhan
[Feature] Add new Fwlinks for v6 help content
717b57f 
Updated fwlinks to pull new help content for PSv6.
Fwlink for Microsoft.PowerShell.Core module is not updated since about_*help.txt is not available yet.
@adityapatwardhan

adityapatwardhan commented Oct 19, 2017

Copy link
Copy Markdown
Member Author

@daxian-dbw I have updated PR and the required help content is also fixed. All tests pass now. Please have another look.

@daxian-dbw daxian-dbw merged commit df06200 into PowerShell:master Oct 23, 2017
@adityapatwardhan adityapatwardhan deleted the HelpUri branch November 1, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@charub charub Awaiting requested review from charub

@Francisco-Gamino Francisco-Gamino Awaiting requested review from Francisco-Gamino

+1 more reviewer

@joeyaiello joeyaiello joeyaiello approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @joeyaiello @daxian-dbw @SteveL-MSFT
Morty Proxy This is a proxified and sanitized view of the page, visit original site.