Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert pester portion of Added Meta, Charset, and Transitional parame…#4881

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:Revert_PesterTravisEz13/PowerShell:Revert_PesterCopy head branch name to clipboard
Sep 20, 2017
Merged

Revert pester portion of Added Meta, Charset, and Transitional parame…#4881
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
TravisEz13:Revert_PesterTravisEz13/PowerShell:Revert_PesterCopy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Sep 20, 2017

Copy link
Copy Markdown
Member

…ters to ConvertTo-HTML (#4184)

(reverted from commit bbc180a)

My understanding is that #4184 reverted the pester submodule. This is reverting it back.
@JamesWTruher contacted me. I'm not sure of the exact issue.

From @JamesWTruher:

a previous merge bbc180a incorrectly included pester changes. Most likely because that individual did not update his submodules.

@daxian-dbw

Copy link
Copy Markdown
Member

@TravisEz13 Can you please add a PR description to explain why we are reverting it?

@JamesWTruher

Copy link
Copy Markdown
Collaborator

a previous merge bbc180a incorrectly included pester changes. Most likely because that individual did not update his submodules.

@daxian-dbw daxian-dbw merged commit 4c6ad4a into PowerShell:master Sep 20, 2017
@SteveL-MSFT

Copy link
Copy Markdown
Member

is there any downside to having start-psbuild do a git submodule update?

@TravisEz13 TravisEz13 deleted the Revert_Pester branch September 27, 2017 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.