Updated default ModuleVersion in ModuleManifest#4842
Updated default ModuleVersion in ModuleManifest#4842adityapatwardhan merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom LDSpits:feature/update-manifestversionCopy head branch name to clipboard
Conversation
|
@LDSpits, It will cover your contributions to all Microsoft-managed open source projects. |
|
@LDSpits, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
| new UTF8Encoding(false), // UTF-8, no BOM | ||
| #else | ||
| EncodingConversion.Unicode, // UTF-16 with BOM | ||
| #endif |
There was a problem hiding this comment.
Is this part of change caused by some character encoding? If no intentional change was made, you can get rid of it by using git reset HEAD^ and then git add -p (ignore this change section when adding).
There was a problem hiding this comment.
As part of #4761 (comment), this file has mixed EOL characters. We can accept it to make the EOLs the same for this file or ignore it as I'm fixing this across the entire codebase in a separate PR.
There was a problem hiding this comment.
OK, then we can accept this part of the changes.
This pull request updates the New-ModuleManifest command to generate a ModuleVersion manifest property with 0.0.1 instead of 1.0. specified by the discussion in #4823.