Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

validate the expected output package exists when using start-pspackage#4795

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:test-packageSteveL-MSFT/PowerShell:test-packageCopy head branch name to clipboard
Sep 11, 2017
Merged

validate the expected output package exists when using start-pspackage#4795
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:test-packageSteveL-MSFT/PowerShell:test-packageCopy head branch name to clipboard

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

Fix #4760
also fixed small typo

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

Start-NativeExecution -sb {dotnet $arguments} | Foreach-Object {Write-Verbose $_}

Get-ChildItem $nugetFolder\* | Select-Object -ExpandProperty FullName
$nupkgFile = "${nugetFolder}\${nuspecPackageName}-${packageRuntime}.${nugetSemanticVersion}.nupkg"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the full name... you don't need the get-childitem anymore.

@TravisEz13 TravisEz13 merged commit 3815a95 into PowerShell:master Sep 11, 2017
@SteveL-MSFT SteveL-MSFT deleted the test-package branch October 16, 2017 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build is green if an MSI could not be produced due to e.g. a WiX compilation error

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.