Add a generic file watcher function in HelpersCommon.psm1#4775
Add a generic file watcher function in HelpersCommon.psm1#4775
Conversation
|
|
||
| # Loop until the script block evaluates to true | ||
| while (-not ($sb.Invoke())) { | ||
| # If the timeout period has passed, return false |
There was a problem hiding this comment.
Interesting, make sense to enhance Invoke() to support timeout?
There was a problem hiding this comment.
You can do async invocation via powershell API, though the experience is not optimal.
| $startTime = [DateTime]::Now | ||
|
|
||
| # Loop until the file is present | ||
| while (-not (Test-Path $File)) { |
There was a problem hiding this comment.
Maybe use Wait-UntilTrue? We duplicate code here.
There was a problem hiding this comment.
Good point. I will change it.
| while (((Get-Date) - $startTime).TotalSeconds -lt 10 -and (-not (Test-Path "$HOME/nativeCommandProcessor.Success"))) { | ||
| Start-Sleep -Milliseconds 100 | ||
| } | ||
| Wait-FileToBePresent -File "$HOME/nativeCommandProcessor.Success" -TimeoutInSeconds 10 -IntervalInMilliseconds 100 > $null |
There was a problem hiding this comment.
Every use we add ">$null" - so maybe do this internally in Wait-FileToBePresent ? If we need we could add -Passthrou
And why not use Out-Null? It is optimized for pipelines.
There was a problem hiding this comment.
Will change to ignore output in Wait-FileToBePresent. -PassThru can be added when there is a need coming up.
As for Out-Null, I think the optimization was to make Out-Null same as > $null when it's the last command in a pipeline, namely writing to null pipe directly without going through the cmdlet.
|
The failure in AppVeyor is a known issue. It's fixed by #4806 |
Fix #4524
Add a generic file watcher function in HelpersCommon.psm1 and update some tests to use the
Wait-FileToBePresent.