Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove double spaces between words in resx files (#4740)#4741

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
korygill:masterkorygill/PowerShell:masterCopy head branch name to clipboard
Sep 3, 2017
Merged

Remove double spaces between words in resx files (#4740)#4741
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
korygill:masterkorygill/PowerShell:masterCopy head branch name to clipboard

Conversation

@korygill

@korygill korygill commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

Fix for issue #4740.

@msftclas

msftclas commented Sep 2, 2017

Copy link
Copy Markdown

@korygill,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

iSazonov
iSazonov approved these changes Sep 2, 2017
View reviewed changes

@iSazonov iSazonov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korygill Thanks for fixing the typos!

markekraus
markekraus approved these changes Sep 2, 2017
View reviewed changes

@markekraus markekraus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SteveL-MSFT
SteveL-MSFT approved these changes Sep 2, 2017
View reviewed changes

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markekraus

markekraus commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

@SteveL-MSFT Thinking about this further, couldn't some of these possibly be Bucket 2 or 3 breaking changes since they modify errors that some may be relying on?

@SteveL-MSFT

SteveL-MSFT commented Sep 3, 2017

Copy link
Copy Markdown
Member

@markekraus users should not rely on parsing error messages as they can be localized. the error messages are meant for humans to read. automation should rely on things like the FullyQualifiedErrorId and Exception types.

@markekraus

markekraus commented Sep 3, 2017

Copy link
Copy Markdown
Contributor

@SteveL-MSFT Thanks! I was pretty sure that would be the answer but wanted to verify.

@iSazonov

iSazonov commented Sep 3, 2017

Copy link
Copy Markdown
Collaborator

We even have examples of where we changed (removed and added) FullyQualifiedErrorId and Exception types - this was due to error correction or the addition of new features and was therefore not considered an invalid or destructive change.

@iSazonov iSazonov self-assigned this Sep 3, 2017
@iSazonov iSazonov merged commit c14648e into PowerShell:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@dantraMSFT dantraMSFT Awaiting requested review from dantraMSFT

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@markekraus markekraus markekraus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@korygill @msftclas @markekraus @SteveL-MSFT @iSazonov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.