Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[feature] Mark Multiple Response Header Test Pending#4640

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:MultiResponseHeadertestPendingmarkekraus/PowerShell:MultiResponseHeadertestPendingCopy head branch name to clipboard
Aug 22, 2017
Merged

[feature] Mark Multiple Response Header Test Pending#4640
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:MultiResponseHeadertestPendingmarkekraus/PowerShell:MultiResponseHeadertestPendingCopy head branch name to clipboard

Conversation

@markekraus

Copy link
Copy Markdown
Contributor

The Verifies Invoke-WebRequest Supports Multiple response headers with same name test from #4494 is failing on Linux and macOS due to an implementation difference of HttpListener on Linux and macOS where multiple response headers are concatenated instead of sent as separate headers.

In Windows:

HTTP/1.1 200 OK
Content-Length: 2
Content-Type: text/plain
Server: Microsoft-HTTPAPI/2.0
X-Fake-Header: testvalue01
X-Fake-Header: testvalue02
Date: Tue, 22 Aug 2017 09:49:37 GMT

In Linux/macOS:

HTTP/1.1 200 OK
X-Fake-Header: testvalue01, testvalue02
Server: Microsoft-NetCore/2.0
Date: Tue, 22 Aug 2017 09:18:18 GMT
Content-Type: text/plain
Content-Length: 2

This is not a failure of the test but an issue with the current method used for serving test content with HttpListener.

Issue #4639 has been created to track creating a cross-platform multiple header response solution for this test. In the mean time, mark this test as pending to prevent nightly failures.

@msftclas

Copy link
Copy Markdown

@markekraus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@markekraus markekraus force-pushed the MultiResponseHeadertestPending branch from bc1b82f to 39e3023 Compare August 22, 2017 10:02
@anmenaga anmenaga requested a review from SteveL-MSFT August 22, 2017 19:54
@anmenaga

Copy link
Copy Markdown

@TravisEz13 @SteveL-MSFT This needs to be merged asap as it fixes a failure in night test pass.

@TravisEz13

Copy link
Copy Markdown
Member

merging before 24 hours, because this fixes a test failure. @anmenaga Please in the future, be clear if you reviewed the change.

@TravisEz13 TravisEz13 merged commit 5941b89 into PowerShell:master Aug 22, 2017
@markekraus markekraus deleted the MultiResponseHeadertestPending branch August 25, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.