Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update install scripts with minor fixes targeting macOS#4631

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
DarwinJS:issue4511and4617Copy head branch name to clipboard
Aug 22, 2017
Merged

Update install scripts with minor fixes targeting macOS#4631
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
DarwinJS:issue4511and4617Copy head branch name to clipboard

Conversation

@DarwinJS

@DarwinJS DarwinJS commented Aug 21, 2017

Copy link
Copy Markdown
Contributor

Fixes #4617
Fixes #4511
Change VS code install to use cask
Change OSX to use curl
Update version number by point release.

test url and version bump

changed git suburl back to production location
@msftclas

Copy link
Copy Markdown

@DarwinJS,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@TravisEz13

Copy link
Copy Markdown
Member

Please make sure that you add a meaningful title per the contribution guide.
Please use the present tense, imperative style for commit messages and title per Contribution Guide

@TravisEz13 TravisEz13 changed the title fix issues 4511 and 4617 Update install scripts with minor fixes targeting macOS Aug 21, 2017
@TravisEz13

Copy link
Copy Markdown
Member

I updated the title to something more appropriate

@TravisEz13

Copy link
Copy Markdown
Member

When a PR fixes an issues, please include in the description (not title), Fixes #1234. I've updated your PR description for you.

@TravisEz13

Copy link
Copy Markdown
Member

LGTM, I'll leave this open for comment for about 24 hours.

@TravisEz13 TravisEz13 self-assigned this Aug 21, 2017
@TravisEz13 TravisEz13 merged commit ece7b44 into PowerShell:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.