Remove last-modified from headers from travis CI script#4522
Remove last-modified from headers from travis CI script#4522TravisEz13 merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom JamesWTruher:jameswtruher/travisbadgefix10JamesWTruher/PowerShell-1:jameswtruher/travisbadgefix10Copy head branch name to clipboard
Conversation
…g the daily badge
| @@ -50,7 +50,6 @@ function Set-DailyBuildBadge | ||
| $headers = @{ |
There was a problem hiding this comment.
$now is not used any more. We should remove it.
There was a problem hiding this comment.
It is still being used in x-ms-date
There was a problem hiding this comment.
it's still used - two lines higher
|
Can we add more description in the PR as to how this change fixes the issue. |
|
Also, AppVeyor failed in filesystem provider tests. Can we investigate? |
|
@JamesWTruher Please also add the issue it fixes. |
|
it looks like failure is in new test code that went in on 8/2 from jeffbi, i'm not sure whether this is a new failure, with a change only in travis.ps1 I'm having difficulty believing my change caused this. |
|
@adityapatwardhan updated description |
|
is there a way to restart the job in appveyor? |
|
@JamesWTruher Restarted the AppVeyor build. |
It causes a no such resource error when used
When invoke-webrequest is invoked, the call fails with a resource not found error and the badge is not updated. The documentation is pretty spotty with regard to what that resource (last-modified) could have done. It should be enough to set the cache-control header value to let browsers know to refresh the badge value rather than pulling it from cache.
this change should enable the PowerShell main page to report the proper state of the daily build on travis.