Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix deviceguard test failure#4436

Closed
SteveL-MSFT wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:deviceguardSteveL-MSFT/PowerShell:deviceguardCopy head branch name to clipboard
Closed

Fix deviceguard test failure#4436
SteveL-MSFT wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:deviceguardSteveL-MSFT/PowerShell:deviceguardCopy head branch name to clipboard

Conversation

@SteveL-MSFT

@SteveL-MSFT SteveL-MSFT commented Jul 31, 2017

Copy link
Copy Markdown
Member

investigating deviceguard failure. only failing on AppVeyor.

@daxian-dbw

daxian-dbw commented Jul 31, 2017

Copy link
Copy Markdown
Member

The DeviceGuard test is still failing:

[-] Test for DeviceGuard properties 107ms
   Expected {0} to be greater than {0}
   at line: 1392 in C:\projects\powershell\test\powershell\Modules\Microsoft.PowerShell.Management\Get-ComputerInfo.Tests.ps1
   1392:                     $observed.DeviceGuardRequiredSecurityProperties.Count | Should BeGreaterThan 0

@SteveL-MSFT SteveL-MSFT mentioned this pull request Jul 31, 2017
Merged
@SteveL-MSFT SteveL-MSFT force-pushed the deviceguard branch 3 times, most recently from 15b2979 to 0eedb26 Compare July 31, 2017 21:19
@SteveL-MSFT
[Feature]
9f5568e 
Failure is due to WMI class returning a value of 0 which is not defined.
Adding additional value to enum being used to account for this.
@adityapatwardhan

adityapatwardhan commented Jul 31, 2017

Copy link
Copy Markdown
Member

If this is the only failure blocking daily builds, should we mark this test as pending on Windows, till we figure out the root cause. We have not had a successful daily build in about 19 days.

@SteveL-MSFT

SteveL-MSFT commented Aug 1, 2017

Copy link
Copy Markdown
Member Author

@adityapatwardhan good idea, I'll submit that as a different PR so I can keep investigating this

@SteveL-MSFT SteveL-MSFT mentioned this pull request Aug 1, 2017
Merged
@iSazonov

iSazonov commented Aug 15, 2017

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT Maybe close the PR?

@SteveL-MSFT SteveL-MSFT deleted the deviceguard branch October 26, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@adityapatwardhan adityapatwardhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SteveL-MSFT @daxian-dbw @adityapatwardhan @iSazonov @msftclas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.