Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add amazonlinux compatibility in install-powershell.sh#4360

Merged
TravisEz13 merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
DarwinJS:issue4359-amazonlinux-compatibilityCopy head branch name to clipboard
Aug 1, 2017
Merged

add amazonlinux compatibility in install-powershell.sh#4360
TravisEz13 merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
DarwinJS:issue4359-amazonlinux-compatibilityCopy head branch name to clipboard

Conversation

@DarwinJS

Copy link
Copy Markdown
Contributor

Amazon linux is a fine mix of CentOS versions ;) Needed to make a few adaptations to get the installer working for it. It might also pickup older versions of CentOS that use /etc/system-release instead of /etc/redhat-release

@msftclas

Copy link
Copy Markdown

@DarwinJS,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@DarwinJS DarwinJS changed the title Issue4359 amazonlinux compatibility Issue4359 amazonlinux compatibility for install-powershell.sh Jul 27, 2017
@DarwinJS

Copy link
Copy Markdown
Contributor Author

Tested and working on AMI:
ami-c58c1dd3 (amzn-ami-hvm-2017.03.0.20170417-x86_64-gp2)
Had to download install-powershell.sh and installpsh-redhat.sh and chmod 755.

@TravisEz13

Copy link
Copy Markdown
Member

It would be good if we have a way of testing this. Do you want to create a docker file with amazonlinux https://hub.docker.com/_/amazonlinux/ which we can use to verify this works during a release?

@DarwinJS

Copy link
Copy Markdown
Contributor Author

@TravisEz13 - not sure - the changes were quite moderate - probably just changes needed to support earlier versions of CentOS.

Do we test all the other supported distros and versions for the installer?

@TravisEz13

Copy link
Copy Markdown
Member

If you don't think it's needed, please file an issue and mention this PR. It's not much work if the installer is working.

Also, Please use the present tense, imperative style for commit messages and title per Contribution Guide

@DarwinJS

Copy link
Copy Markdown
Contributor Author

@TravisEz13 - I'm not sure what I should be putting in the issue? This PR is against issue 4359. If you mean that I file one for the docker file - do you mean I ask for one to be made or mention that one is not needed?

@DarwinJS

Copy link
Copy Markdown
Contributor Author

@TravisEz13 - I might be interested in doing the docker file. Is there an existing pattern or guidance document? I looked around for docker files in the testing files of the repository - I found one - but can't tell exactly how to wire a new dockerfile into the automated testing.

@TravisEz13

Copy link
Copy Markdown
Member

@DarwinJS Just write a docker file, similar to the ones in https://github.com/PowerShell/PowerShell/tree/master/docker/release and then add it to the list of tests cases here: https://github.com/PowerShell/PowerShell/blob/master/docker/tests/containerTestCommon.psm1#L68
There is a md on how to run the tests in the same folder.

The issue would say that the above needs to be done.

@TravisEz13 TravisEz13 changed the title Issue4359 amazonlinux compatibility for install-powershell.sh add amazonlinux compatibility in install-powershell.sh Aug 1, 2017
@TravisEz13

Copy link
Copy Markdown
Member

docker file submitted on #4393

@TravisEz13 TravisEz13 merged commit b7b3b69 into PowerShell:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.