Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Small grammar change to pull requests guide#4322

Merged
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
zjalexander-patch-1PowerShell/PowerShell:zjalexander-patch-1Copy head branch name to clipboard
Aug 4, 2017
Merged

Small grammar change to pull requests guide#4322
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
zjalexander-patch-1PowerShell/PowerShell:zjalexander-patch-1Copy head branch name to clipboard

Conversation

@zjalexander

Copy link
Copy Markdown
Contributor

him -> them, which is consistent with usage above.

him -> them, which is consistent with usage above.
@msftclas

Copy link
Copy Markdown

@zjalexander,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Them is more appropriate than him but perhaps we should adopt a writing style to guide this. Here is a link to guidance on resolving this for APA Style

@TravisEz13

TravisEz13 commented Jul 24, 2017

Copy link
Copy Markdown
Member

Please fix PR title
Please use the present tense, imperative style for commit messages and title per Contribution Guide
Suggestion Remove gender specific language in PR process

@zjalexander zjalexander changed the title style change Small grammar change to pull requests guide Jul 24, 2017
@TravisEz13 TravisEz13 merged commit 7d5367a into master Aug 4, 2017
@TravisEz13 TravisEz13 deleted the zjalexander-patch-1 branch August 4, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.