Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

added test coverage for -notcontains, -is, -isnot operators#4179

Merged
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:test-operatorsSteveL-MSFT/PowerShell:test-operatorsCopy head branch name to clipboard
Jul 11, 2017
Merged

added test coverage for -notcontains, -is, -isnot operators#4179
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:test-operatorsSteveL-MSFT/PowerShell:test-operatorsCopy head branch name to clipboard

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

-like and -contains already has coverage

Fix #4162

$arr= 'Hello','world'
$arr -contains 'Hello' | Should Be $true
It "Should be <result> for 'Hello','world' <operator> <rhs>" -TestCases @(
@{result = $true; operator = "-contains"; rhs = "'Hello'"},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for case sensitive variants? ccontains and cnotcontains? There are some tests below. Can we move them to this It and add it as part of -TestCases array.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some general cleanup of the tests

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

@adityapatwardhan addressed

@adityapatwardhan adityapatwardhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.