Close FileStream opened to read file go get hash.#4175
Merged
lzybkr merged 1 commit intoJul 7, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
rkeithhill:rkeithhill/fix-get-filehash-open-handlerkeithhill/PowerShell:rkeithhill/fix-get-filehash-open-handleCopy head branch name to clipboard
Merged
Close FileStream opened to read file go get hash.#4175lzybkr merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom rkeithhill:rkeithhill/fix-get-filehash-open-handlerkeithhill/PowerShell:rkeithhill/fix-get-filehash-open-handleCopy head branch name to clipboard
lzybkr merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
rkeithhill:rkeithhill/fix-get-filehash-open-handlerkeithhill/PowerShell:rkeithhill/fix-get-filehash-open-handleCopy head branch name to clipboard
Conversation
SteveL-MSFT
reviewed
Jul 2, 2017
| try | ||
| { | ||
| Stream openfilestream = File.OpenRead(path); | ||
| openfilestream = File.OpenRead(path); |
Collaborator
Author
|
I went with that approach first but with the catch statement it seemed to read better with |
Collaborator
|
LGTM. |
Member
|
@rkeithhill looking at the entire file, keeping it try...finally is probably more consistent with other try...catch usage in this file, so LGTM |
SteveL-MSFT
approved these changes
Jul 3, 2017
Collaborator
Author
|
Sure would be nice to get this fix into beta.4. Got some Plaster users on Linux who are hitting this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4174