Fixed test to not create a file called 1 when run#4021
Closed
SteveL-MSFT wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:incorrect-comparision-operatorSteveL-MSFT/PowerShell:incorrect-comparision-operatorCopy head branch name to clipboard
Closed
Fixed test to not create a file called 1 when run#4021SteveL-MSFT wants to merge 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom SteveL-MSFT:incorrect-comparision-operatorSteveL-MSFT/PowerShell:incorrect-comparision-operatorCopy head branch name to clipboard
1 when run#4021SteveL-MSFT wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:incorrect-comparision-operatorSteveL-MSFT/PowerShell:incorrect-comparision-operatorCopy head branch name to clipboard
Conversation
… originally resulted into created a file called `1`
Member
|
I fixed this same thing in PR #3800 but it doesn't look like it was merged. |
Member
Author
|
@MiaRomero didn't see your PR, closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
Start-PSPestera file called1was being created. This is due to incorrect usage of a redirection operator>when it should have been the comparison operator-gt. After fixing this, a newcode path started executing which had incorrect assumption as the Format-Hex cmdlet works with
16-bytes at a time, so fixed that logic.