Allow use of long paths#3960
Merged
lzybkr merged 2 commits intoJun 8, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
jeffbi:item-exists-3891Copy head branch name to clipboard
Merged
Allow use of long paths#3960lzybkr merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom jeffbi:item-exists-3891Copy head branch name to clipboard
lzybkr merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
jeffbi:item-exists-3891Copy head branch name to clipboard
Conversation
When calling Windows native API to determine if an item exists, ensure the path is prepended with "\\?\" to allow for long paths.
lzybkr
reviewed
Jun 7, 2017
| internal static extern int GetFileAttributes(string lpFileName); | ||
| private static string EnsureLongPathPrefix(string path) | ||
| { | ||
| if (!path.StartsWith(@"\\?\", StringComparison.Ordinal)) |
Contributor
There was a problem hiding this comment.
Can we skip adding the prefix when the path is short?
Always adding the prefix will create a lot of garbage I think.
lzybkr
approved these changes
Jun 8, 2017
This was referenced Jun 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3891
When calling Windows native API to determine if an item exists, ensure the path is prepended with
\\?\to allow for paths > 260 characters.